-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15455][network] Enabled tcp connection reuse across multi jobs. #18417
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4ef0a82 (Thu Jan 20 09:13:18 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KarmaGYZ. I've went through the production codes and have some comments mostly concerning the code complexity and readability. I'd prefer to look into the testing codes later, as they are likely to be changed while addressing these comments.
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
Outdated
Show resolved
Hide resolved
...java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactory.java
Outdated
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClient.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/util/AtomicDisposableReferenceCounter.java
Outdated
Show resolved
Hide resolved
f4b00ff
to
78c2513
Compare
Thanks for the review @xintongsong . PR updated. |
...ime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClient.java
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClient.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactory.java
Outdated
Show resolved
Hide resolved
.../org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandlerTest.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactory.java
Outdated
Show resolved
Hide resolved
78c2513
to
0377901
Compare
@xintongsong Thanks for the review. PR updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments, @KarmaGYZ. LGTM.
.../org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandlerTest.java
Outdated
Show resolved
Hide resolved
0377901
to
0cbdc41
Compare
To avoid the memory leak in the record map for deduplication.
4a8fa79
to
b243dd4
Compare
b243dd4
to
45a1c20
Compare
@flinkbot run azure |
What is the purpose of the change
Enabled tcp connection reuse across multi jobs.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation