Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15455][network] Enabled tcp connection reuse across multi jobs. #18417

Closed
wants to merge 2 commits into from

Conversation

KarmaGYZ
Copy link
Contributor

@KarmaGYZ KarmaGYZ commented Jan 20, 2022

What is the purpose of the change

Enabled tcp connection reuse across multi jobs.

Verifying this change

This change added tests and can be verified as follows:

  • NettyPartitionRequestClientTest#testPartitionRequestClientReuse

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@KarmaGYZ
Copy link
Contributor Author

cc @xintongsong @wsry

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4ef0a82 (Thu Jan 20 09:13:18 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 20, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KarmaGYZ. I've went through the production codes and have some comments mostly concerning the code complexity and readability. I'd prefer to look into the testing codes later, as they are likely to be changed while addressing these comments.

@KarmaGYZ KarmaGYZ force-pushed the FLINK-15455 branch 3 times, most recently from f4b00ff to 78c2513 Compare February 7, 2022 05:21
@KarmaGYZ
Copy link
Contributor Author

KarmaGYZ commented Feb 7, 2022

Thanks for the review @xintongsong . PR updated.

@KarmaGYZ
Copy link
Contributor Author

@xintongsong Thanks for the review. PR updated.

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, @KarmaGYZ. LGTM.

To avoid the memory leak in the record map for deduplication.
@KarmaGYZ KarmaGYZ force-pushed the FLINK-15455 branch 4 times, most recently from 4a8fa79 to b243dd4 Compare February 15, 2022 09:02
@KarmaGYZ
Copy link
Contributor Author

@flinkbot run azure

@KarmaGYZ KarmaGYZ closed this in 5be7d48 Feb 16, 2022
MrWhiteSike pushed a commit to MrWhiteSike/flink that referenced this pull request Mar 3, 2022
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants