Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25041][BP 1.14][e2e] Improve error handling for missing environment variables in E2E tests #18599

Merged
merged 1 commit into from Feb 9, 2022

Conversation

autophagy
Copy link
Contributor

Backport of #17896

…iables in E2E tests

There are several points where the E2E tests check that an environment
variable is nonempty before proceeding with the tests, such as the
E2E_TARBALL_CACHE. Usually, this results in a friendly error message
stating "You have to export the E2E Tarball Cache as E2E_TARBALL_CACHE".

However, if running the scripts with nounset during development, this results
in an `E2E_TARBALL_CACHE: unbound variable` error, which is less friendly to
the user.

This PR changes these instances to use parameter expansion for these
variables, so that even with nounset, the user recieves the friendly
error message for a missing environment variable.
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 1, 2022

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4717680 (Tue Feb 01 16:43:34 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 1, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol zentol merged commit c06e3bb into apache:release-1.14 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants