-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25892][test] archunit tests for connectors test code #18623
Conversation
48a85e5
to
dfae1d3
Compare
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 48a85e5 (Thu Feb 03 16:04:51 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
42617c4
to
b217619
Compare
[FLINK-25892][hive][test] bugs fix [FLINK-25892][hive][test] bugs fix
b217619
to
4283a7c
Compare
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @JingGe.
Just for public documentation purposes, we discussed privately whether the TestCodeArchitectureTest
classes should be located in o.a.f.architecture or o.a.f..architecture. We decided to leave them in the former for now, but it'd be easy to change too.
This was merged manually. |
What is the purpose of the change
Add ArchUnit tests for the test code of each connector. This is the follow-up PR for the ticket FLINK-25220.
Brief change log
Verifying this change
This change add architectural tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation