Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25892][test] archunit tests for connectors test code #18623

Closed
wants to merge 22 commits into from

Conversation

JingGe
Copy link
Contributor

@JingGe JingGe commented Feb 3, 2022

What is the purpose of the change

Add ArchUnit tests for the test code of each connector. This is the follow-up PR for the ticket FLINK-25220.

Brief change log

  • Add ArchUnit tests for the test code of each connector.
  • add archunit.properties
  • Init violation stores

Verifying this change

This change add architectural tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@JingGe JingGe force-pushed the FLINK-25892-archunit-connectors branch from 48a85e5 to dfae1d3 Compare February 3, 2022 16:04
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 3, 2022

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 48a85e5 (Thu Feb 03 16:04:51 UTC 2022)

Warnings:

  • 18 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 3, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JingGe JingGe force-pushed the FLINK-25892-archunit-connectors branch 2 times, most recently from 42617c4 to b217619 Compare February 3, 2022 20:11
@JingGe JingGe force-pushed the FLINK-25892-archunit-connectors branch from b217619 to 4283a7c Compare February 4, 2022 01:08
@Airblader Airblader self-requested a review February 4, 2022 07:08
@JingGe
Copy link
Contributor Author

JingGe commented Feb 4, 2022

@flinkbot run azure

Copy link
Contributor

@Airblader Airblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @JingGe.

Just for public documentation purposes, we discussed privately whether the TestCodeArchitectureTest classes should be located in o.a.f.architecture or o.a.f..architecture. We decided to leave them in the former for now, but it'd be easy to change too.

@Airblader
Copy link
Contributor

This was merged manually.

@Airblader Airblader closed this Feb 7, 2022
@JingGe JingGe deleted the FLINK-25892-archunit-connectors branch February 8, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants