New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25697][Runtime / Metrics] introduce port url config for prometheus push gateway a… #18668
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9b618d7 (Tue Feb 08 18:22:27 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…nd deprecate host/port configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prometheus reporter documentation contains an example config that also needs an update.
...metheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterFactory.java
Outdated
Show resolved
Hide resolved
...metheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
Outdated
Show resolved
Hide resolved
...eus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterTest.java
Outdated
Show resolved
Hide resolved
...eus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterTest.java
Show resolved
Hide resolved
8dcc81a
to
7a6501c
Compare
@flinkbot run azure |
…nd deprecate host/port configs
What is the purpose of the change
Support scheme specification in Prometheus Push Gateway Reporter
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation