Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25583] Support compacting small files for FileSink. #18680

Closed
wants to merge 6 commits into from

Conversation

pltbkd
Copy link
Contributor

@pltbkd pltbkd commented Feb 9, 2022

What is the purpose of the change

This pull request makes the FileSink to support compacting small files, based on the new extended sink API.

Brief change log

  • Users may enable compaction when building FileSink by calling enableCompact.
  • Committables emitted from FileWriter will be collected by CompactCoordinator and reorgnized into CompactRequests according to the user defined FileCompactStrategy.
  • CompactRequests will be sent to CompactorOperators then executed, and the results will be sent to the committers, as if it's created by the writers.
  • FileCompactor is introduced to execute the compaction, and several basic implementations are provided.

Verifying this change

This change added some unit tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (yes)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 9, 2022

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2ff898d (Wed Feb 09 08:53:09 UTC 2022)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 9, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@pltbkd
Copy link
Contributor Author

pltbkd commented Feb 9, 2022

The branch is force pushed to add a hotfix before all commits, to fix the bug in SinkTransformationTranslator that sets parallelism of transformations added in the per-commit topology without checking if the parallelism is set.

@pltbkd
Copy link
Contributor Author

pltbkd commented Feb 10, 2022

@gaoyunhaii
Thanks for the suggestions.
The commits are reorgnized to be more clear, and about 2/3 comments are resolved. I'm still working on the remaining ones.

@pltbkd pltbkd force-pushed the file_compact_review branch 2 times, most recently from 1327927 to de9803e Compare February 11, 2022 09:36
@pltbkd
Copy link
Contributor Author

pltbkd commented Feb 11, 2022

All comments so far are resolved now.

@gaoyunhaii
Copy link
Contributor

Thanks @pltbkd for the update! I try to fixed some tests. Also, could you have a look that if the two *StateHandle needs snapshotState ?

@pltbkd
Copy link
Contributor Author

pltbkd commented Feb 16, 2022

Thanks @pltbkd for the update! I try to fixed some tests. Also, could you have a look that if the two *StateHandle needs snapshotState ?

Cleaning up of the state is added when the remaining state is drained in the handlers. Nothing special is necessary while snapshotting the state. I suppose we don't need to implement a customized snapshotState. I have added some comments to explain this.

@pltbkd
Copy link
Contributor Author

pltbkd commented Feb 16, 2022

@flinkbot run azure

Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after ci get greeen.

@gaoyunhaii
Copy link
Contributor

@flinkbot run azure

MrWhiteSike pushed a commit to MrWhiteSike/flink that referenced this pull request Mar 3, 2022
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants