Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3732] [Core] Potential null deference in ExecutionConfig#equals() #1871

Closed
wants to merge 3 commits into from
Closed

Conversation

skyahead
Copy link
Contributor

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@StephanEwen
Copy link
Contributor

Code looks good, but it triggers a checkstyle violation: indentation includes a space.
Please have a look at the Travis CI logs...

@StephanEwen
Copy link
Contributor

Looks good. Failed test seems to be a Scala compiler issue, not related to this pull request.

Merging this...

fhueske pushed a commit to fhueske/flink that referenced this pull request Apr 15, 2016
@asfgit asfgit closed this in f3d3a44 Apr 15, 2016
kl0u pushed a commit to kl0u/flink that referenced this pull request Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants