Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22781][table-planner-blink] Fix bug that when implements the LookupFunction In SQL that indirect extends (Async)TableFunction, throw exception #18719

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adiaixin
Copy link

…ookupFunction In SQL that indirect extends (Async)TableFunction, throw exception

What is the purpose of the change

when implements the LookupFunction In SQL that indirect extends (Async)TableFunction, we extract the output type class use ExtractionUtils#extractSimpleGeneric, this method will return empty when dealing with indirect extended subclasses. We need to fix this bug.

Brief change log

  • change method ExtractionUtils#extractSimpleGeneric, traverse all the super classes to the base class until find the generic parameter in pos has real class type.

Verifying this change

(Please pick either of the following options)

This change added tests and can be verified as follows:

  • Added a unit Test which verified the static method result. (org.apache.flink.table.utils.ExtractionUtilsTest)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

…ookupFunction In SQL that indirect extends (Async)TableFunction, throw exception
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 11, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d8153a4 (Fri Feb 11 08:01:54 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@adiaixin
Copy link
Author

@flinkbot run azure

@adiaixin
Copy link
Author

@twalthr
hi, could you review this pr when you are free ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants