-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-26180] Update docs to introduce the compaction for FileSink. #18797
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 716d8eb (Wed Feb 16 08:32:18 UTC 2022) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pltbkd for the PR! I have one comment~
the cached files will be scheduled to compact. | ||
|
||
The {{< javadoc file="org/apache/flink/connector/file/sink/compactor/FileCompactor.html" name="FileCompactor">}} specifies how to compact | ||
the give list of `Path` and write the result to {{< javadoc file="org/apache/flink/connector/file/sink/filesystem/CompactingFileWriter.html" name="CompactingFileWriter">}}. It could be classified into two types according to the type of the give `CompactingFileWriter`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to CompactingFileWriter seems not right. Also the same with the Chinese version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
…paction for FileSink.
716d8eb
to
270a217
Compare
Thanks @pltbkd for the update! LGTM~ The failed test should be irrelevant~ |
…paction for FileSink. This closes apache#18797.
…paction for FileSink. This closes apache#18797.
What is the purpose of the change
This pull request update docs to introduce the compaction for FileSink.
Brief change log