Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26331] Make cleanup retry strategy configurable similar to how the task restart is configurable #18913

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Feb 24, 2022

What is the purpose of the change

The goal is to align the user experience for retry functionality. I created a follow-up ticket FLINK-26359 to cover the actual alignment in the code.

Brief change log

  • Introduced CleanupOptions similar to RestartOptions to give a consistent user experience.
  • Adds CleanupRetryStrategyFactory covering the configuration extraction to create the right RetryStrategy instance
  • Updated docs

Verifying this change

  • CleanupRetryStrategyFactoryTest is added to cover all different options

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? docs, JavaDoc

@XComp XComp marked this pull request as draft February 24, 2022 18:41
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a2dec76 (Thu Feb 24 18:44:30 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor Author

XComp commented Feb 24, 2022

The compiled docs look like that:
Screenshot 2022-02-24 at 21 46 14

Copy link
Contributor

@autophagy autophagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small documentation suggestions, and just a comment so I better understand what the enum factory pattern is for - but otherwise lgtm!

…configuration pattern for task restarts

The issue is that repeatable cleanups leverage
the RetryStrategy. In contrast, task restarts
use RestartBackoffTimeStrategy. We might want to
align these two approaches and provide a generic
interface to allow retries. FLINK-26359 was
created to cover this.
@XComp
Copy link
Contributor Author

XComp commented Feb 28, 2022

Thanks @autophagy for your review. I applied your comments, squashed the commits and rebased the branch. I will merge it after the final CI run succeeds.

@XComp
Copy link
Contributor Author

XComp commented Feb 28, 2022

Test failure unrelated to changes: FLINK-26387 I'm going to merge the PR

@XComp XComp merged commit 2e627a1 into apache:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants