New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-26354] -restoreMode should be --restoreMode and should have a shorthand #18918
Conversation
f4c9997
to
6c95910
Compare
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f4c9997 (Fri Feb 25 08:29:11 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR. I have left some comments, please take a look.
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendRunTest.java
Outdated
Show resolved
Hide resolved
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendRunTest.java
Outdated
Show resolved
Hide resolved
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendRunTest.java
Outdated
Show resolved
Hide resolved
6c95910
to
ea82ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Add shorthand option for restoreMode
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation