New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-26494][runtime] Cleanup does not reveal exceptions #18987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XComp
force-pushed
the
FLINK-26494
branch
3 times, most recently
from
March 7, 2022 11:26
57c71a7
to
1ba1816
Compare
zentol
requested changes
Mar 9, 2022
...untime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/DefaultResourceCleaner.java
Outdated
Show resolved
Hide resolved
...untime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/DefaultResourceCleaner.java
Outdated
Show resolved
Hide resolved
...untime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java
Outdated
Show resolved
Hide resolved
...untime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/DefaultResourceCleaner.java
Show resolved
Hide resolved
Thanks for your review, @zentol . I addressed your comments. PTAL |
zentol
reviewed
Mar 9, 2022
...untime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/DefaultResourceCleaner.java
Outdated
Show resolved
Hide resolved
zentol
approved these changes
Mar 10, 2022
…ption LocalFileSystem.listStatus returns null in case of the path being invalid.
Updated the commit messages and rebased to the most recent version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The retryable cleanup works but does not reveal the actual error which makes it harder to identify the error. This PR fixes it.
Brief change log
DefaultResourceCleaner.Builder
method signatures for adding cleanups are extended to also require a label that is passed. The label should be unique to make each cleanup identifyable in the logs.Verifying this change
DefaultResourceCleanerTest
methods with logging enabledDoes this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation