Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26565][TABLE][TRIGGER]use later trigger for delay window when laterTrigger is not null #18993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hehuiyuan
Copy link
Contributor

What is the purpose of the change

When a record arrived and the window is not exist, it will emit the window result immediately.

` if (triggerTime(window) <= ctx.getCurrentWatermark()) {
// we are in the late phase

                // if there is no late trigger then we fire on every late element
                // This also covers the case of recovery after a failure
                // where the currentWatermark will be Long.MIN_VALUE
                return true;

}`

I think it can use lateTrigger, if user set "table.exec.emit.late-fire.delay".

@hehuiyuan hehuiyuan changed the title use later trigger for delay window when laterTrigger is not null [TABLE][TRIGGER]use later trigger for delay window when laterTrigger is not null Mar 7, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 7, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hehuiyuan hehuiyuan changed the title [TABLE][TRIGGER]use later trigger for delay window when laterTrigger is not null [FLINK-26565][TABLE][TRIGGER]use later trigger for delay window when laterTrigger is not null Mar 10, 2022
@hehuiyuan hehuiyuan force-pushed the latetrigger branch 3 times, most recently from bd1444c to 6b2a149 Compare March 14, 2022 13:55
@hehuiyuan
Copy link
Contributor Author

Hi @wuchong , take a look when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants