Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26805][table] Managed table breaks legacy connector without 'connector.type' #19201

Merged
merged 2 commits into from Mar 23, 2022

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

Fix the bug, Managed table breaks:

CREATE TABLE T (a INT) WITH ('type'='legacy');
INSERT INTO T VALUES (1); 

This case can be misinterpreted as a managed table, which the user might expect to be resolved by the legacy table factory.

Brief change log

  • Move isLegacyConnectorOptions to TableFactoryUtil.
  • ManagedTableListener.isManagedTable should exclude legacy connector.

Verifying this change

  • LegacyTableFactoryTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JingsongLi JingsongLi merged commit 6e63e6c into apache:release-1.15 Mar 23, 2022
JingsongLi added a commit to JingsongLi/flink that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants