[FLINK-26928][connector/kafka] Remove unnecessary Docker network creation in tests #19282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Mar 30, 2022
| if (numBrokers > 1) { | ||
| Network network = Network.newNetwork(); |
There was a problem hiding this comment.
I think a cleaner way to avoid 'ERROR: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network' is release the created network resources after used it.
There was a problem hiding this comment.
Thanks for the review @leonardBang ! Fixed in e4e1d24.
…tion in tests and close network on shutdown()
leonardBang
approved these changes
Mar 30, 2022
PatrickRen
added a commit
to PatrickRen/flink
that referenced
this pull request
Mar 31, 2022
…tion in tests and close network on shutdown() This closes apache#19282. (cherry picked from commit 47a1f32)
JasonLeeCoding
pushed a commit
to JasonLeeCoding/flink
that referenced
this pull request
May 27, 2022
…tion in tests and close network on shutdown() This closes apache#19282.
zstraw
pushed a commit
to zstraw/flink
that referenced
this pull request
Jul 4, 2022
…tion in tests and close network on shutdown() This closes apache#19282.
jnh5y
pushed a commit
to jnh5y/flink
that referenced
this pull request
Dec 18, 2023
…tion in tests and close network on shutdown() This closes apache#19282.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request removes unnecessary Docker network creation in Kafka connector tests.
Brief change log
Verifying this change
This change is already covered by existing Kafka connector tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation