Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27239][table-planner] rewrite PreValidateReWriter from scala to java #19465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xuyangzhong
Copy link
Contributor

What is the purpose of the change

This pr aims to do the processing task about FLIP-28 and rewrite PreValidateReWriter implemented from Scala to Java.

Brief change log

  • rewrite PreValidateReWriter implemented from Scala to Java.

Verifying this change

Current tests can verify this change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 14, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xuyangzhong
Copy link
Contributor Author

@flinkbot run azure

@xuyangzhong
Copy link
Contributor Author

xuyangzhong commented Apr 14, 2022

I think one of the failed test cases "ScalarFunctionsTest.testExtract" is not caused by this pr, because other azure results have same failed cases like :https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=34648&view=results

@xuyangzhong xuyangzhong force-pushed the master_zxy_rewrite_PreValidateReWriter branch from 215549f to e8fdb5e Compare April 15, 2022 02:19
@xuyangzhong
Copy link
Contributor Author

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants