Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27265][docs] Flink comes with five built-in BulkWriter factories instead of the mentioned four in filesystem.md. #19489

Merged
merged 1 commit into from Apr 19, 2022

Conversation

empcl
Copy link
Contributor

@empcl empcl commented Apr 15, 2022

What is the purpose of the change

in filesystem.md, flink comes with four built-in BulkWriter factories, in fact, the list has five.

Brief change log

in filesystem.md, flink comes with four built-in BulkWriter factories, in fact, the list has five.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

yes

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 15, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser
Copy link
Contributor

@chenlei677 Thanks for the PR. Please check and follow the code contribution guide at https://flink.apache.org/contributing/contribute-code.html and update your PR, else it can't get merged.

@empcl empcl changed the title in filesystem.md, flink comes with four built-in BulkWriter factories… [FLINK-27265] in filesystem.md, flink comes with four built-in BulkWriter factories… Apr 15, 2022
@empcl empcl changed the title [FLINK-27265] in filesystem.md, flink comes with four built-in BulkWriter factories… [FLINK-27265] in filesystem.md, flink comes with four built-in BulkWriter factories… Apr 15, 2022
@MartijnVisser MartijnVisser self-assigned this Apr 19, 2022
…es instead of the mentioned four in filesystem.md. This closes #19489
@MartijnVisser MartijnVisser changed the title [FLINK-27265] in filesystem.md, flink comes with four built-in BulkWriter factories… [FLINK-27265][docs] Flink comes with five built-in BulkWriter factories instead of the mentioned four in filesystem.md. Apr 19, 2022
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@empcl Thank you for the PR. For your next PR, please make sure that you're following Flink's Code Contribution Guide as documented at https://flink.apache.org/contributing/contribute-code.html

I've fixed your commit message this time and corrected the PR, but this is normally not done by someone in the community but should be taken care of by the contributor.

@MartijnVisser MartijnVisser merged commit 6f70421 into apache:master Apr 19, 2022
ChengkaiYang2022 pushed a commit to ChengkaiYang2022/flink-25705 that referenced this pull request May 7, 2022
…es instead of the mentioned four in filesystem.md. This closes apache#19489
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…es instead of the mentioned four in filesystem.md. This closes apache#19489
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
…es instead of the mentioned four in filesystem.md. This closes apache#19489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants