Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27272][table-planner] Fix the incorrect plan for query with local sort is incorrect if adaptive batch scheduler is enabled #19497

Closed
wants to merge 1 commit into from

Conversation

godfreyhe
Copy link
Contributor

What is the purpose of the change

See the bug detail in the JIRA description. The solution is 1) correct the RequireDistribution derivation for local BatchPhysicalRank, 2) add logic in ForwardHashExchangeProcessor to handle local sort case

Brief change log

  • correct the RequireDistribution derivation for local BatchPhysicalRank
  • add logic in ForwardHashExchangeProcessor to handle local sort case

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This change added tests and can be verified as follows:

  • Extended ForwardHashExchangeTest to verify the change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…cal sort is incorrect if adaptive batch scheduler is enabled
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 17, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wenlong88
Copy link
Contributor

LGTM

@godfreyhe godfreyhe closed this in 456ceb2 Apr 18, 2022
@godfreyhe godfreyhe deleted the FLINK-27272 branch April 18, 2022 02:27
godfreyhe added a commit that referenced this pull request Apr 18, 2022
…cal sort is incorrect if adaptive batch scheduler is enabled

(cherry picked from commit 456ceb2)

This closes #19497
ChengkaiYang2022 pushed a commit to ChengkaiYang2022/flink-25705 that referenced this pull request May 7, 2022
…cal sort is incorrect if adaptive batch scheduler is enabled

This closes apache#19497
sergeitsar pushed a commit to fentik/flink that referenced this pull request May 19, 2022
…cal sort is incorrect if adaptive batch scheduler is enabled

(cherry picked from commit 456ceb2)

This closes apache#19497
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…cal sort is incorrect if adaptive batch scheduler is enabled

This closes apache#19497
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
…cal sort is incorrect if adaptive batch scheduler is enabled

This closes apache#19497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants