-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jackson version upgrade: default from 2.4.2 to 2.7.4 (latest stable) #1952
Conversation
…ext minor version); elastic client to latest patch
@fhueske jackson-databind is only used in the Table API to render the explain output. We should be good to update to latest there as well, right? |
Yes, I hope so. |
@cowtowncoder do you see a reason for not upgrading all the way to 2.7? |
@aljoscha @fhueske Nothing special, just thought I'd start with smallest step, given that this is my first contribution here. |
ElasticSearch 2.x requires jackson >= 2.6.2, hence the Elastic 2.x connector jackson version is set at 2.7.x. Locally, I changed the Jackson version to be 2.7.x in the parent pom and didn't see any issues or tests failures. I think its safe to change the jackson.version to 2.7.4 in parent pom. If so, please remove the <jackson.version> in ElasticSearch2/pom.xml |
@smarthi Updated as suggested. |
The build now fails consistently for the wikipedia connector? Could you push another dummy commit to rerun travis tests. Let's see if it goes away. |
The IRC Wikimedia channel is timing out and hence the reason for Wiki test failures, nothing to do with this PR. LGTM IMO |
I'm running a last local test and then merging this. Thanks for the work! 😃 |
Merging |
Fix for [FLINK-3855] -- upgrade default Jackson version from 2.4.2 to 2.5.5 (last 2.5 patch); remove unnecessary explicit version ref, and upgrade ES client to latest patch for minor version it refers.