Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson version upgrade: default from 2.4.2 to 2.7.4 (latest stable) #1952

Closed
wants to merge 2 commits into from
Closed

Conversation

cowtowncoder
Copy link
Contributor

Fix for [FLINK-3855] -- upgrade default Jackson version from 2.4.2 to 2.5.5 (last 2.5 patch); remove unnecessary explicit version ref, and upgrade ES client to latest patch for minor version it refers.

…ext minor version); elastic client to latest patch
@aljoscha
Copy link
Contributor

aljoscha commented May 2, 2016

@fhueske jackson-databind is only used in the Table API to render the explain output. We should be good to update to latest there as well, right?

@fhueske
Copy link
Contributor

fhueske commented May 2, 2016

Yes, I hope so.

@aljoscha
Copy link
Contributor

aljoscha commented May 2, 2016

@cowtowncoder do you see a reason for not upgrading all the way to 2.7?

@cowtowncoder
Copy link
Contributor Author

@aljoscha @fhueske Nothing special, just thought I'd start with smallest step, given that this is my first contribution here.
But given that 2.7.4 is out now, I agree that going right there does make most sense and should be safe.
It also looks like most usage is via Tree API (JsonNodes), some streaming; most changes are typically in databinding and very few compatibility issues occur outside databinding. So to me upgrade seems safe either way. And since Elastic-client already uses 2.7 that would allow unification of versions as well.

@smarthi
Copy link
Member

smarthi commented May 3, 2016

ElasticSearch 2.x requires jackson >= 2.6.2, hence the Elastic 2.x connector jackson version is set at 2.7.x. Locally, I changed the Jackson version to be 2.7.x in the parent pom and didn't see any issues or tests failures. I think its safe to change the jackson.version to 2.7.4 in parent pom. If so, please remove the <jackson.version> in ElasticSearch2/pom.xml

@cowtowncoder cowtowncoder changed the title Jackson version upgrade: default from 2.4.2 to 2.5.5, ES client to latest 2.7 Jackson version upgrade: default from 2.4.2 to 2.7.4 (latest stable) May 3, 2016
@cowtowncoder
Copy link
Contributor Author

@smarthi Updated as suggested.

@aljoscha
Copy link
Contributor

aljoscha commented May 3, 2016

The build now fails consistently for the wikipedia connector? Could you push another dummy commit to rerun travis tests. Let's see if it goes away.

@smarthi
Copy link
Member

smarthi commented May 3, 2016

The IRC Wikimedia channel is timing out and hence the reason for Wiki test failures, nothing to do with this PR.

LGTM IMO

@aljoscha
Copy link
Contributor

aljoscha commented May 9, 2016

I'm running a last local test and then merging this. Thanks for the work! 😃

@fhueske
Copy link
Contributor

fhueske commented May 13, 2016

Merging

@asfgit asfgit closed this in 780c7f3 May 13, 2016
gna-phetsarath pushed a commit to gna-phetsarath/flink that referenced this pull request May 13, 2016
markreddy pushed a commit to markreddy/flink that referenced this pull request May 14, 2016
mbode pushed a commit to mbode/flink that referenced this pull request May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants