-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-27382][runtime] Moves cluster shutdown to when the job cleanup is done in job mode #19567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autophagy
reviewed
Apr 26, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
Outdated
Show resolved
Hide resolved
The force-push also included a rebase to fix the |
I added a hotfix commit in addition to the actual change. PTAL. |
XComp
commented
Apr 26, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
Outdated
Show resolved
Hide resolved
Force-pushed to fix spotless error |
autophagy
approved these changes
Apr 28, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
Outdated
Show resolved
Hide resolved
zentol
reviewed
Apr 28, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
Outdated
Show resolved
Hide resolved
zentol
reviewed
Apr 28, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
Outdated
Show resolved
Hide resolved
XComp
force-pushed
the
FLINK-27382
branch
2 times, most recently
from
April 28, 2022 12:10
b0874a8
to
568d79f
Compare
Fixed compilation error and force-pushed... |
… is done in job mode
…unner result completes exceptionally Additionally, I moved the test's documentation into the production code because it makes more sense to have the reasoning over there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In job mode, we triggered the shutdown as soon as the job reached a globally terminal state. This was fine in 1.14- because we didn't do any promises on the cleanup anyway. With 1.15, we introduced retries for cleanup which results in the final termination taking longer. During cluster shutdown the ResourceManager is informed about deregistering the cluster which results in the workers being shutdown in case of active RMs (i.e. k8s and YARN). See further details in FLINK-26772 (parent issue of this issue).
Brief change log
Dispatcher#jobReachedTerminalState
inMiniDispatcher
MiniDispatcher
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation