Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26052][docs-zh] Document savepoint format #19616

Merged
merged 1 commit into from May 6, 2022

Conversation

zoltar9264
Copy link
Contributor

What is the purpose of the change

Update Chinese documentation regarding FLIP-203

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented May 1, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dawidwys
Copy link
Contributor

dawidwys commented May 2, 2022

cc @Myasuka @curcur do you mind taking a look?

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR!
I think you missed to translate the part of Stopping a Job with Savepoint which also introduce the savepoint format.

docs/content.zh/docs/ops/state/savepoints.md Outdated Show resolved Hide resolved
@zoltar9264
Copy link
Contributor Author

Sorry for missed the part of Stopping a Job with Savepoint, the English doc for this part was added after this issue was created, I didn't notice. I will add it soon.

@zoltar9264
Copy link
Contributor Author

Sorry for missed the part of Stopping a Job with Savepoint, the English doc for this part was added after this issue was created, I didn't notice. I will add it soon.

Done.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the suggestion.

docs/content.zh/docs/ops/state/savepoints.md Outdated Show resolved Hide resolved
Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you squash all commits into one?

@zoltar9264
Copy link
Contributor Author

Thanks @Myasuka . Sure, I have done.

@Myasuka Myasuka merged commit f26bfd4 into apache:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants