[FLINK-27185][connectors] Convert connector modules to assertj #19660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpreu
changed the title
|
@flinkbot run azure |
afedulov
suggested changes
May 9, 2022
There was a problem hiding this comment.
@alpreu I finished reviewing the first commit ([FLINK-27185][connectors] Convert connector modules to assertj #19660) and left a couple of comments.
...test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java
Outdated
Show resolved
Hide resolved
...ector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceTest.java
Outdated
Show resolved
Hide resolved
...or-base/src/test/java/org/apache/flink/connector/base/source/reader/SourceMetricsITCase.java
Outdated
Show resolved
Hide resolved
...se/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherTest.java
Outdated
Show resolved
Hide resolved
afedulov
suggested changes
May 9, 2022
There was a problem hiding this comment.
Just one comment regarding the [FLINK-27185][connector] Convert connector-cassandra module to assertj commit. Looks good apart from that.
.../src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Outdated
Show resolved
Hide resolved
afedulov
suggested changes
May 10, 2022
There was a problem hiding this comment.
Review for [FLINK-27185][connector] Convert connector-elasticsearch modules to assertj is finished.
...ch-base/src/test/java/org/apache/flink/connector/elasticsearch/table/IndexGeneratorTest.java
Show resolved
Hide resolved
...ava/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorFactoryTest.java
Show resolved
Hide resolved
afedulov
suggested changes
May 12, 2022
There was a problem hiding this comment.
Finished reviewing [FLINK-27185][connector] Convert connector-hive module to assertj.
Looks almost good, there are mostly some missed opportunities to use assertThatThrownBy.
...nector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDeserializeExceptionTest.java
Outdated
Show resolved
Hide resolved
...s/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
Outdated
Show resolved
Hide resolved
...s/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
Outdated
Show resolved
Hide resolved
...nnector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...nnector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...rs/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveRunnerITCase.java
Outdated
Show resolved
Hide resolved
...flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java
Outdated
Show resolved
Hide resolved
...k-connector-hive/src/test/java/org/apache/flink/table/functions/hive/HiveGenericUDFTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
…ssertj Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
Co-authored-by: slinkydeveloper <francescoguard@gmail.com>
alpreu
force-pushed
the
hotfix-migrate-connectors-2
branch
from
96766d1
to
fffd289
Compare
|
[FLINK-27185][connector] Convert connector-base module to assertj + addressed review |
|
connector-cassandra module also looks good. |
|
connector-elasticsearch module looks good. |
|
connector-hive module looks good apart from the potential improvement here #19660 (comment). Can be merged when addressed. |
afedulov
suggested changes
May 18, 2022
There was a problem hiding this comment.
Finished reviewing [FLINK-27185][connector] Convert connector-jdbc module to assertj. Potentially some missed opportunities to use assertThatThrownBy.
...rc/test/java/org/apache/flink/connector/jdbc/split/NumericBetweenParametersProviderTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
afedulov
suggested changes
May 18, 2022
There was a problem hiding this comment.
Finished reviwing [FLINK-27185][connector] Convert connector-kafka module to assertj. Feel free to ignore the bits that might relate to the already deprecated components.
...ink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java
Outdated
Show resolved
Hide resolved
...ink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java
Outdated
Show resolved
Hide resolved
...ink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java
Outdated
Show resolved
Hide resolved
...ink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java
Outdated
Show resolved
Hide resolved
...ink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java
Show resolved
Hide resolved
...ka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java
Show resolved
Hide resolved
...ka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Show resolved
Hide resolved
...ka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Show resolved
Hide resolved
...ka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java
Show resolved
Hide resolved
...a/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
Show resolved
Hide resolved
afedulov
suggested changes
May 18, 2022
There was a problem hiding this comment.
FInished reviwing [FLINK-27185][connector] Convert connector-kinesis module to assertj. Let's try to reduce Hamcrest dependencies where possible.
...is/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Outdated
Show resolved
Hide resolved
...is/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Outdated
Show resolved
Hide resolved
...is/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Show resolved
Hide resolved
...is/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Outdated
Show resolved
Hide resolved
...is/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Outdated
Show resolved
Hide resolved
...esis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
Outdated
Show resolved
Hide resolved
...esis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java
Outdated
Show resolved
Hide resolved
...esis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/RecordEmitterTest.java
Outdated
Show resolved
Hide resolved
...esis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/RecordEmitterTest.java
Outdated
Show resolved
Hide resolved
...esis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/RecordEmitterTest.java
Outdated
Show resolved
Hide resolved
|
connector-jdbc module looks good. |
|
connector-kafka module looks good. |
|
connector-kinesis module looks good. |
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and grandfathers #19425