[FLINK-27741][table-planner] Fix NPE when use dense_rank() and rank()… #19797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in over aggregation.
xuyangzhong
reviewed
May 27, 2022
| @@ -98,7 +98,7 @@ protected Expression orderKeyEqualsExpression() { | |||
| equalTo(lasValue, operand(i))); | |||
| } | |||
| Optional<Expression> ret = Arrays.stream(orderKeyEquals).reduce(ExpressionBuilder::and); | |||
| return ret.orElseGet(() -> literal(true)); | |||
| return ret.orElseGet(() -> literal(false)); | |||
There was a problem hiding this comment.
Hi, I just wander why this value should be changed ?
There was a problem hiding this comment.
@xuyangzhong The default value of true will cause the sort value to be unchanged, which I don't think conforms to the semantics of sorting.
| @@ -159,6 +159,66 @@ class OverAggregateITCase(mode: StateBackendMode) extends StreamingWithStateTest | |||
| assertEquals(expected.sorted, sink.getAppendResults.sorted) | |||
| } | |||
|
|
|||
| @Test | |||
| def testDenseRankOnOver(): Unit = { | |||
There was a problem hiding this comment.
Maybe you can add some test cases for testing plan, not only just for ITCases.
There was a problem hiding this comment.
Hi, @xuyangzhong . Thanks for your review and sorry for delay response. I didn't find the UT of AggFunctionFactory, so I borrowed the test for ROW_NUMBER. And I haven't waited for the community's reply, I can add corresponding unit tests later if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NPE when use dense_rank() and rank() in over aggregation.
What is the purpose of the change
This pull request fixes NullPointException when use DENSE_RANK() and RANK() for an append stream.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation