[FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions #19873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
snuyanzin
force-pushed
the
flink27891
branch
from
2e65622
to
f64c3ce
Compare
snuyanzin
force-pushed
the
flink27891
branch
2 times, most recently
from
a218b77
to
7ee5c01
Compare
liuyongvs
reviewed
Mar 27, 2023
| Arrays.asList( | ||
| ARRAY_ELEMENT_ARG1, logical(LogicalTypeRoot.ARRAY)))) | ||
| .outputTypeStrategy(nullableIfArgs(argument(1))) | ||
| .runtimeClass( |
There was a problem hiding this comment.
.outputTypeStrategy(nullableIfArgs(argument(1))) is not correct
...-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
Show resolved
Hide resolved
|
yes i will |
|
rebased to fix conflicts |
snuyanzin
force-pushed
the
flink27891
branch
2 times, most recently
from
0380508
to
2478dac
Compare
liuyongvs
reviewed
Apr 6, 2023
...n/java/org/apache/flink/table/types/inference/strategies/ArrayAppendPrependTypeStrategy.java
Show resolved
Hide resolved
|
rebased since there were several build failure fixes in master |
snuyanzin
force-pushed
the
flink27891
branch
2 times, most recently
from
d60012b
to
09580aa
Compare
|
@flinkbot run azure |
|
@snuyanzin thanks for your pr, LGTM |
|
@snuyanzin Are you still working on finalizing this PR? |
|
ah.. sorry completely forgot abou it |
|
@MartijnVisser since there is a feature freeze do you think it makes sense to add it in 1.19? Otherwise I'm going to add it when a new release starts |
|
Let's add it for 1.20, and honor the feature freeze |
snuyanzin
force-pushed
the
flink27891
branch
from
ac09e6d
to
a7cb97e
Compare
|
rebased to resolve conflicts |
snuyanzin
force-pushed
the
flink27891
branch
2 times, most recently
from
7fb37ff
to
33f3d2d
Compare
snuyanzin
force-pushed
the
flink27891
branch
from
33f3d2d
to
f638db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is an implementation of
ARRAY_APPENDandARRAY_PREPENDinspired by #19543Brief change log
Verifying this change
This change added tests in
CollectionFunctionsITCaseDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes )Documentation