-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-27902][runtime] Refactor ResultPartitionType to decouple scheduling and partition release logic #19885
[FLINK-27902][runtime] Refactor ResultPartitionType to decouple scheduling and partition release logic #19885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR, @reswqa. The refactor looks good in general. I have only a few comments. Please take a look.
...runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java
Outdated
Show resolved
Hide resolved
...runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTrackerImpl.java
Show resolved
Hide resolved
...runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java
Show resolved
Hide resolved
…nType to decoupling scheduling and partition release.
…us isPipelined calls that actually judge whether the downstream can consume data when upstream is not finish.
…place some previous isPipelined,isBlocking and isReconnectable calls that actually refer to partition release logical.
…to replace some previous isPipelined calls that actually judge whether the resultPartitionType is Pipelined or PipelinedBounded.
… and replace all remaining isBlocking calls.
…ble in ResultPartitionType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are only one minor comment, plus that commit messages should indicate the relevant component. I'll fix them while merging this.
...runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java
Show resolved
Hide resolved
…econnectable in ResultPartitionType. This closes apache#19885
…econnectable in ResultPartitionType. This closes apache#19885
…econnectable in ResultPartitionType. This closes apache#19885
What is the purpose of the change
Refactor ResultPartitionType to decouple scheduling and partition release logic
Brief change log
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation