Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27902][runtime] Refactor ResultPartitionType to decouple scheduling and partition release logic #19885

Closed
wants to merge 8 commits into from
Closed

[FLINK-27902][runtime] Refactor ResultPartitionType to decouple scheduling and partition release logic #19885

wants to merge 8 commits into from

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Jun 6, 2022

What is the purpose of the change

Refactor ResultPartitionType to decouple scheduling and partition release logic

Brief change log

  • *Introduce ConsumeType indicates when can the downstream consume the upstream. *
  • Introduce ReleaseType indicates who is responsible for releasing the result partition.
  • Using ConsumeType and ReleaseType instead of isPipelined and isReconnectable in scheduling and partition release related code.
  • Remove useless isPipelined, isBlocking and isReconnectable in ResultPartitionType.

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 6, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR, @reswqa. The refactor looks good in general. I have only a few comments. Please take a look.

…nType to decoupling scheduling and partition release.
…us isPipelined calls that actually judge whether the downstream can consume data when upstream is not finish.
…place some previous isPipelined,isBlocking and isReconnectable calls that actually refer to partition release logical.
…to replace some previous isPipelined calls that actually judge whether the resultPartitionType is Pipelined or PipelinedBounded.
… and replace all remaining isBlocking calls.
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are only one minor comment, plus that commit messages should indicate the relevant component. I'll fix them while merging this.

huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Jun 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants