Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15855][hive] Use the new type inference for Hive UDAF #19920

Merged
merged 1 commit into from Jul 6, 2022

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Jun 9, 2022

What is the purpose of the change

Use new type inference for Hive UDAF

Brief change log

  • Stop using AggregateFunctionDefinition in HiveFunctionDefinitionFactory
  • Remove HiveLegacyFunction, HiveAggSqlFunction, HiveFunctionUtils
  • Add a HiveParserOperatorBinding and create AggregateCall with the HiveParserOperatorBinding to make HiveGenericUFAF can get literal arguments

Verifying this change

existing tests and added test in udaf.q.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 9, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong
Copy link
Member

wuchong commented Jul 5, 2022

@flinkbot run azure

1 similar comment
@wuchong
Copy link
Member

wuchong commented Jul 6, 2022

@flinkbot run azure

@wuchong wuchong merged commit bcd619f into apache:master Jul 6, 2022
ericccarlson pushed a commit to ericccarlson/flink that referenced this pull request Jul 11, 2022
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants