New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-27890][examples] Fix the bug introduced By [FLINK-19317] to use the return result after assignTimestampsAndWatermarks #19924
Conversation
@coderappee You've ended up with two apparently identical commits in this PR. Could you clean that up, please? |
Could you tell me how to do it? Close this pull request and then roll back the last two commit and recommit again? |
Squash the two commits to one, and force push to you own repo branch coderappee:FLINK-27890,it will update this pull request automatically. |
@coderappee Let me know if you're stuck, and I can take care of this when I merge the PR. In this particular situation, it should be enough to rollback the last commit in your branch and then force push to the branch in your fork that is the basis for this PR. |
…e the return result after assignTimestampsAndWatermarks
I rollback the last commit, then use "git commit --amend" to add some changes to last second commit, and then force push to the branch for this PR. |
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @coderappee for your contribution!
What is the purpose of the change
Fix the SideOutputExample bug introduced by [FLINK-19317].
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation