Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27937][tests][pubsub] Migrate flink-connectors-gcp-pubsub to JUnit 5 #19928

Merged
merged 1 commit into from Sep 12, 2022

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

Migrate flink-connectors-gcp-pubsub module to AssertJ and JUnit 5 following the JUnit 5 Migration Guide

Brief change log

  1. Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest
  2. Add dependency on mockito-junit-jupiter since pubsub connector requires it

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no )
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 10, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @snuyanzin. In general, the PR looks good. I just have one comment where I need a bit of clarification.

@XComp XComp merged commit ea3ff8e into apache:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants