Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-27996][hive] Hive dialect supports interval type #19955

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Jun 14, 2022

What is the purpose of the change

To support interval type in Hive dialect

Brief change log

  • Add data mapping in HiveTypeUtil.java. Hive's INTERVAL_YEAR_MONTH / INTERVAL_DAY_TIME is mapped to DataTypes.INTERVAL(DataTypes.MONTH()) / DataTypes.INTERVAL(DataTypes.SECOND(3))
  • Add converter in HiveInspectors.java between Hive's data and Flink's data. Hive's HiveIntervalYearMonth/ HiveIntervalDayTime should be converted to Period/Duration , and the vice verse.
  • Port Hive's internal_interval function GenericUDFInternalInterval to hive-connector as HiveGenericUDFInternalInterval and adjust it to make it's consistent to Flink's HiveParser.
  • Overwrite the implementation of Hive's internal_interval function with the ported HiveGenericUDFInternalInterval.

Verifying this change

Added test in interval.q

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 14, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 8cae2e7 into apache:master Jul 21, 2022
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants