New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28193][runtime] Enable to identify whether a job vertex contains source/sink operators #20043
Conversation
ba3c08d
to
c0fed33
Compare
c0fed33
to
1ed1778
Compare
Could you not infer this from the size of |
A job vertex with no input/output does not mean it is a true source/sink vertex.
This was mentioned in the JIRA description. I will add it to the PR description. |
1ed1778
to
547f946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @zhuzhurk.
The changes look good to me. I only had one minor comment. Please take a look.
...ming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
Outdated
Show resolved
Hide resolved
…ns source/sink operators
547f946
to
8011116
Compare
Thanks for the reviewing! @wanglijie95 |
…ns source/sink operators This closes apache#20043.
…ns source/sink operators This closes apache#20043.
…ns source/sink operators This closes apache#20043.
…ns source/sink operators This closes apache#20043.
…ns source/sink operators This closes apache#20043.
What is the purpose of the change
Speculative execution does not support sources/sinks in the first version. Therefore, it will not create speculation instances for vertices which contains source/sink operators.
Note that a job vertex with no input/output does not mean it is a true source/sink vertex:
In this pr, we introduce methods to check whether a job vertex contains source/sink operators.
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation