-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28212][hive] Trim the project node with window expressions to fix IndexOutOfBoundsException when using Hive dialect. #20060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@flinkbot run azure |
wuchong
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you rebase and fix the conflicts @luoyuxia ?
…fix IndexOutOfBoundsException when using Hive dialect.
@flinkbot run azure |
The failed case is tracked by FLINK-28789. |
snuyanzin
pushed a commit
to snuyanzin/flink
that referenced
this pull request
Aug 4, 2022
…indow SELECT doesn't contain all fields of input This closes apache#20060
chaozwn
pushed a commit
to chaozwn/flink
that referenced
this pull request
Aug 5, 2022
…indow SELECT doesn't contain all fields of input This closes apache#20060
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…indow SELECT doesn't contain all fields of input This closes apache#20060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To fix the
IndexOutOfBoundsException
for window expression while using Hive dialectBrief change log
Verifying this change
Added test in ...connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation