Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28212][hive] Trim the project node with window expressions to fix IndexOutOfBoundsException when using Hive dialect. #20060

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Jun 23, 2022

What is the purpose of the change

To fix the IndexOutOfBoundsException for window expression while using Hive dialect

Brief change log

Verifying this change

Added test in ...connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? N/A

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 23, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@luoyuxia
Copy link
Contributor Author

@flinkbot run azure

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you rebase and fix the conflicts @luoyuxia ?

…fix IndexOutOfBoundsException when using Hive dialect.
@wuchong
Copy link
Member

wuchong commented Aug 3, 2022

@flinkbot run azure

2 similar comments
@luoyuxia
Copy link
Contributor Author

luoyuxia commented Aug 4, 2022

@flinkbot run azure

@luoyuxia
Copy link
Contributor Author

luoyuxia commented Aug 4, 2022

@flinkbot run azure

@wuchong
Copy link
Member

wuchong commented Aug 4, 2022

The failed case is tracked by FLINK-28789.
Merging...

@wuchong wuchong merged commit 42287b3 into apache:master Aug 4, 2022
snuyanzin pushed a commit to snuyanzin/flink that referenced this pull request Aug 4, 2022
…indow SELECT doesn't contain all fields of input

This closes apache#20060
chaozwn pushed a commit to chaozwn/flink that referenced this pull request Aug 5, 2022
…indow SELECT doesn't contain all fields of input

This closes apache#20060
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…indow SELECT doesn't contain all fields of input

This closes apache#20060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants