-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect #20071
Conversation
@flinkbot run azure |
Thanks @luoyuxia for fixing the issue. Should we also add test cases for grouping function with multiple parameters? |
@lirui-apache Thanks for reminder. I add a test for it to make sure this changes won't break such case. |
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
I don't think the e2e test failure is related but I guess we need a green run to merge. @luoyuxia could you post your own CI result if it's successful? |
…n when over window contains grouping function in Hive dialect
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
@lirui-apache The CI is passed now~ |
…n when over window contains grouping function in Hive dialect This closes apache#20071.
…n when over window contains grouping function in Hive dialect This closes apache#20071.
…n when over window contains grouping function in Hive dialect This closes apache#20071.
What is the purpose of the change
To fix the exception "no any field presented in group by" when over window contains grouping function in Hive dialect like
SELECT grouping(category), lag(live) over(partition by grouping(category)) FROM t GROUP BY category, live
Brief change log
Verifying this change
Added test in HiveDialectQueryITCase.java#testWindowWithGrouping
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation