Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28263][TPCDS][Tests] Clean-up generated data folder by TPCDS test #20083

Merged
merged 1 commit into from Jun 28, 2022

Conversation

MartijnVisser
Copy link
Contributor

What is the purpose of the change

  • The TPCDS tests generated folders/files, but doesn't clean them up afterwards. This causes out of diskspace errors further downstream. This change cleans up those files/folders

Brief change log

  • Remove the folders/files that are generated by TPCDS tests

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 27, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser MartijnVisser force-pushed the FLINK-28263-cleanup branch 5 times, most recently from 1b6630c to 81b2fbb Compare June 28, 2022 08:48
@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser MartijnVisser changed the title [FLINK-28263][TPCDS][Tests] Clean-up generated folders by TPCDS test [FLINK-28263][TPCDS][Tests] Clean-up generated data folder by TPCDS test Jun 28, 2022
Copy link
Contributor

@alpinegizmo alpinegizmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants