[FLINK-27905][runtime] Introduce HsSpillingStrategy and HsSelectiveSpillingStrategy implementation #20100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
changed the title
xintongsong
reviewed
Jul 11, 2022
...e/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSelectiveSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSelectiveSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsAllSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsAllSpillingStrategy.java
Outdated
Show resolved
Hide resolved
xintongsong
reviewed
Jul 12, 2022
...rc/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsAllSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSelectiveSpillingStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSpillingInfoProvider.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/flink/runtime/io/network/partition/hybrid/HybridShuffleConfiguration.java
Outdated
Show resolved
Hide resolved
xintongsong
reviewed
Jul 13, 2022
...t/java/org/apache/flink/runtime/io/network/partition/hybrid/TestingSpillingInfoProvider.java
Outdated
Show resolved
Hide resolved
...st/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSpillingStrategyTestBase.java
Outdated
Show resolved
Hide resolved
...st/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFullSpillingStrategyTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFullSpillingStrategyTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/flink/runtime/io/network/partition/hybrid/HsSelectiveSpillingStrategyTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/flink/runtime/io/network/partition/hybrid/HsSelectiveSpillingStrategyTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @xintongsong, I have resolved all comments, PTAL~ |
…llingStrategy、allSpillingStrategy implementation.
…tiveSpillingStrategy、allSpillingStrategy implementation.
xintongsong
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Thanks @reswqa. LGTM. I have one minor change, please take a look.
Merging this once AZP gives green light.
JunRuiLee
pushed a commit
to JunRuiLee/flink
that referenced
this pull request
Jul 20, 2022
…llingStrategy、allSpillingStrategy implementation. This closes apache#20100
liujiawinds
pushed a commit
to liujiawinds/flink
that referenced
this pull request
Jul 22, 2022
…llingStrategy、allSpillingStrategy implementation. This closes apache#20100
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…llingStrategy、allSpillingStrategy implementation. This closes apache#20100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce
HsSpillingStrategyand ImplementHsSelectiveSpillingStrategyto support make a spilling decision for hybrid shuffle.Brief change log
HsSpillingStrategyinterface for all spilling strategy.HsSelectiveSpillingStrategyto reduce disk writes as much as possible.HsAllSpillingStrategyto spill all data into disk.Verifying this change
Covered by
HsSelectiveSpillingStrategyTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation