Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28296][hive] Support the Hive UDAF which implement GenericUDAFResolver interface #20102

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Jun 29, 2022

What is the purpose of the change

To support these Hive UDAFs that implement GenericUDAFResolver interface.

Brief change log

  • Add a branch to check if the function is only the instance of GenericUDAFResolver when create function definition.
  • If the function is instance of GenericUDAFResolver, call GenericUDAFResolver#getEvaluator(TypeInfo[] parameters) to create GenericUDAFEvaluator in HiveGenericUDAF.java

Verifying this change

Added test to test call the Hive's function that implements GenericUDAFResolve.

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

@luoyuxia luoyuxia changed the title [FLINK-28296][hive] Support the Hive UDAF which implement GenericUDAFResolver interface. [FLINK-28296][hive] Support the Hive UDAF which implement GenericUDAFResolver interface Jun 29, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 29, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit f9bd7d2 into apache:master Aug 5, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants