Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem #20135

Closed
wants to merge 1 commit into from

Conversation

vchangpengfei
Copy link

@vchangpengfei vchangpengfei commented Jul 2, 2022

…ValidatorImpl.class conflict problem

fix class conflict when run in idea

  • when run test org.apache.flink.connector.jdbc.table.JdbcLookupTableITCase.testLookup in local idea,the jar of calcite-core.jar is loaded before mudule of flink-table-planner ,lead to ValidatorImpl.class in calcite-core.jar load priority*

Brief change log

  • change the dependency order in pom

Verifying this change

This change is already covered by existing tests, such as apache.flink.connector.jdbc.table.JdbcLookupTableITCase.testLookup.

before
image
after
image

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? (no)

because flink-table-planner use maven-shade-plugin if run with maven directly is ok,but run in idea may lead to exception

hope to help others in the community, feel free to review
thanks

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 2, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@vchangpengfei vchangpengfei changed the base branch from master to release-1.14 July 2, 2022 01:43
@vchangpengfei vchangpengfei changed the title Flink 28358 [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem Jul 2, 2022
@MartijnVisser MartijnVisser requested a review from zentol July 4, 2022 13:43
@vchangpengfei
Copy link
Author

@zentol @MartijnVisser What's your opinion on this pull request?

@MartijnVisser
Copy link
Contributor

@vchangpengfei We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants