[FLINK-26600][tests] Wait with savepoint until job is running #20162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnVisser
approved these changes
Jul 5, 2022
|
WDYM? It waits indefinitely until the condition is fulfilled. |
I was more worried about it waiting/validating every 50 milliseconds with impact on resource usage, but if it's fine, let's get this merged :) |
|
I see; I don't think we need to worry about that; 50ms is a surprisingly long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only makes sense to trigger savepoints when the job is actually RUNNING. Triggering a savepoint while the job is in the CREATED state is tolerated in the default scheduler (even though the checkpoint will immediately fail), but the adaptive scheduler rejects it eagerly.
Ideally we'd align the behavior in a follow-up.
Ideally ideally the clients would take care of that, but there are quite a few of them and so far they are pretty dumb in that they just forward the request as is. This is possible to change, but it's a larger effort.