Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3728] [tableAPI] Improve error message and documentation for unsupported SQL features. #2018

Closed
wants to merge 1 commit into from

Conversation

fhueske
Copy link
Contributor

@fhueske fhueske commented May 22, 2016

This PR

  1. extends the Table API / SQL documentation and lists known limitations.
  2. improves the error message in case Calcite cannot fails to optimize the program because it includes unsupported features.
  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@fhueske
Copy link
Contributor Author

fhueske commented May 24, 2016

Will merge this later today, unless somebody objects.

@vasia
Copy link
Contributor

vasia commented May 24, 2016

Also looks good! +1.

@fhueske
Copy link
Contributor Author

fhueske commented May 24, 2016

Thanks :-)

@fhueske
Copy link
Contributor Author

fhueske commented May 24, 2016

merging

@asfgit asfgit closed this in 78f5511 May 24, 2016
@fhueske fhueske deleted the tableSupportedFeatures branch May 24, 2016 10:28
mbode pushed a commit to mbode/flink that referenced this pull request May 27, 2016
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants