Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26853][state] Update state serializer in StateMap when metaInfo changed #20268

Merged
merged 1 commit into from Jul 26, 2022

Conversation

masteryhx
Copy link
Contributor

What is the purpose of the change

This pull request makes the state serializer in StateMap could be updated when the RegisteredKeyValueStateBackendMetaInfo in StateTable has been changed.

Brief change log

  • Also update state serializer in CopyOnWriteStateTable#setMetaInfo

Verifying this change

  • Added CopyOnWriteStateTableTest#testSerializerAfterMetaInfoChanged

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 14, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @masteryhx

Production code change LGTM,
I've left some comments about the test, PTAL

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @masteryhx

LGTM

@flinkbot run azure

@rkhachatryan
Copy link
Contributor

@flinkbot run azure

1 similar comment
@masteryhx
Copy link
Contributor Author

@flinkbot run azure

@rkhachatryan rkhachatryan merged commit 8df5053 into apache:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants