[FLINK-28575] [connectors/hbase] support hbase connector 2.2 write to 2.4.9 #20288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to hbase 2.4.9 ### What is the purpose of the change hbase does version checks when creating configurations by default so this prevents using connector2.2 to write to like hbase 2.4.9. however this restriction is not necessary. ### Brief change log add the hbase configuration to skip the version check ### Verifying this change This change added tests and can be verified as follows: hbase-2.2 connector writes normally to hbase 2.4.9 in my local integration ### Does this pull request potentially affect one of the following parts: Dependencies (does it add or upgrade a dependency): no The public API, i.e., is any changed class annotated with @public(Evolving): no The serializers: no The runtime per-record code paths (performance sensitive): no Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no The S3 file system connector: no ### Documentation Does this pull request introduce a new feature? no If yes, how is the feature documented?
MartijnVisser
requested changes
Jul 18, 2022
|
well, if the hbase public APIs are relatively stable (which I believe is the case within minor releases). then I guess there are no reasons down stream will be impacted. |
|
Without testing, you don't know. Yet, when it's broken, people will look at Flink as being the one that's broken. I'm fully onboard with adding support for other versions of HBase, but not like this. I would even prefer to first externalize the HBase connector (like we're doing with all of them) before adding more features to the connector bundled with Flink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support hbase connector 2.2 to write to hbase 2.4.9
What is the purpose of the change
hbase does version checks when creating configurations by default
so this prevents using connector2.2 to write to like hbase 2.4.9. however this restriction is not necessary.
Brief change log
add the hbase configuration to skip the version check
Verifying this change
This change can be verified as follows:
hbase-2.2 connector writes normally to hbase 2.4.9 in my local integration
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no
Documentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented?