[FLINK-3937] Implemented -yid option to Flink cli list, savepoint, cancel and stop subcommands #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,6 +93,7 @@ | |||
|
|
|||
| public FlinkYarnSessionCli(String shortPrefix, String longPrefix) { | |||
| QUERY = new Option(shortPrefix + "q", longPrefix + "query", false, "Display available YARN resources (memory, cores)"); | |||
| APPLICATION_ID = new Option(shortPrefix + "id", longPrefix + "applicationId", true, "Attach to running YARN session"); | |||
There was a problem hiding this comment.
The APPLICATION_ID option is integrated here but the FlinkYarnSessionCli doesn't support attaching to existing applications. I think it could be useful to check during instantiation of the YarnSessionCli in the run(..) method whether we want to start a new application or resume.
|
Thanks for the pull request! Looks good! Do you think we could integrate with the |
|
Thanks for the update! |
|
Merged. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a PR from the patch I already attached to the JIRA issue.