Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-19589][Filesystem][S3] Support per-connector FileSystem configuration #20367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmahonin
Copy link

What is the purpose of the change

Introduces dynamic filesystem configuration for S3

Brief change log

  • Add URI query parameter parsing and apply fs.s3a. entries to Hadoop Configuration for S3/S3A

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This change added tests and can be verified as follows:

  • Added unit test that verifies URI parameters are parsed and applied to Hadoop configuration
  • A version of this is running in production for an S3-backed sink using an AssumedRoleProvider and dynamic role ARN

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: yes

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented

Introduces dynamic filesystem configuration for S3
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 26, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants