Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-3981] don't log duplicate TaskManager registrations #2045

Closed
wants to merge 1 commit into from
Closed

[FLINK-3981] don't log duplicate TaskManager registrations #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java
View file
Open in desktop
Expand Up @@ -354,18 +354,19 @@ private void handleRegisterResource(ActorRef jobManager, ActorRef taskManager,
ResourceID resourceID = msg.resourceId();
try {
Preconditions.checkNotNull(resourceID);
WorkerType newWorker = workerRegistered(resourceID);
WorkerType oldWorker = registeredWorkers.put(resourceID, newWorker);
// check if resourceID is already registered (TaskManager may send duplicate register messages)
WorkerType oldWorker = registeredWorkers.get(resourceID);
if (oldWorker != null) {
LOG.warn("TaskManager {} had been registered before.", resourceID);
LOG.debug("TaskManager {} had been registered before.", resourceID);
} else {
WorkerType newWorker = workerRegistered(resourceID);
registeredWorkers.put(resourceID, newWorker);
LOG.info("TaskManager {} has registered.", resourceID);
}
jobManager.tell(decorateMessage(
new RegisterResourceSuccessful(taskManager, msg)),
self());
} catch (Exception e) {
// This may happen on duplicate task manager registration message to the job manager
LOG.warn("TaskManager resource registration failed for {}", resourceID, e);

// tell the JobManager about the failure
Expand Down