Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese #20510

Closed
wants to merge 4 commits into from

Conversation

Mrzyxing
Copy link
Contributor

@Mrzyxing Mrzyxing commented Aug 9, 2022

What is the purpose of the change

Improve the docs in chinese.

Brief change log

  • Translate the "Real Time Reporting with the Table API" page into Chinese
  • This also fixed a typo on page "Fraud Detection with the DataStream API" in chinese

Verifying this change

No test cases.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( yes )
  • If yes, how is the feature documented? ( docs )

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 9, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@ChengkaiYang2022 ChengkaiYang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mrzyxing Thank you for the contribution! I left some comments, please take a look.
Let me know what you think, I will help to review the rest part after your feedback.

docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Show resolved Hide resolved
@Mrzyxing
Copy link
Contributor Author

@Mrzyxing Thank you for the contribution! I left some comments, please take a look. Let me know what you think, I will help to review the rest part after your feedback.

@ChengkaiYang2022 Thank you very much! Also left some feedback after you and I will push some new commit after we reach an agreement.

@ChengkaiYang2022
Copy link
Contributor

ChengkaiYang2022 commented Aug 15, 2022

@Mrzyxing Thank you for the contribution! I left some comments, please take a look. Let me know what you think, I will help to review the rest part after your feedback.

@ChengkaiYang2022 Thank you very much! Also left some feedback after you and I will push some new commit after we reach an agreement.

@Mrzyxing Thanks for your feedback! Please go ahead.

@Mrzyxing
Copy link
Contributor Author

@ChengkaiYang2022 Fixed and update some translate,let us take this forward!

docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
docs/content.zh/docs/try-flink/table_api.md Outdated Show resolved Hide resolved
@ChengkaiYang2022
Copy link
Contributor

@Mrzyxing I left some comment , please take a look. Looks good to me overall.

@Mrzyxing
Copy link
Contributor Author

@ChengkaiYang2022 Updates, please have a look just when you have time. And will push a final commit after all conversation resolved.

@Mrzyxing
Copy link
Contributor Author

@ChengkaiYang2022 There is one last unresovled conversation, looks like you haven't catch this .
Very expect your ideas.
image

@ChengkaiYang2022
Copy link
Contributor

@ChengkaiYang2022 There is one last unresovled conversation, looks like you haven't catch this . Very expect your ideas. image

@Mrzyxing I think 'Flink 的 Table API 可以简化数据分析、构建数据流水线以及 ETL 应用的定义' is better than '语法糖'.

@Mrzyxing
Copy link
Contributor Author

@ChengkaiYang2022 With your patience and help, all conversation resolved. Thank you very much, expect the next collaborate :-)

@ChengkaiYang2022
Copy link
Contributor

@Mrzyxing Thanks for the contribution! @MartijnVisser Would you help to merge this?

huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants