Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28750][Hive]The field comment for hive ddl has logic error #20548

Open
wants to merge 1 commit into
base: release-1.14
Choose a base branch
from

Conversation

hehuiyuan
Copy link
Contributor

@hehuiyuan hehuiyuan commented Aug 11, 2022

What is the purpose of the change

The field comment is lost when using hive parser. There are som logic error for parsering hive sql

"set table.sql-dialect=hive;\n" +
"CREATE TABLE IF NOT EXISTS myhive.dev.shipu3_test_1125 (\n" +
"   `id` int COMMENT 'iadddd',\n" +
"   `cartdid` bigint COMMENT 'aaa',\n" +
"   `customer` string COMMENT 'vvvv',\n" +
"   `product` string COMMENT 'cccc',\n" +
"   `price` double COMMENT '',\n" +
"   `dt` STRING COMMENT ''\n" +
") PARTITIONED BY (dt STRING) STORED AS TEXTFILE TBLPROPERTIES (\n" +
"  'streaming-source.enable' = 'false',\n" +
"  'streaming-source.partition.include' = 'all',\n" +
"  'lookup.join.cache.ttl' = '12 h'\n" +
")"; 

image

Brief change log

Add field comment for hive ddl

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@hehuiyuan hehuiyuan changed the title add field comment parse for hive ddl [FLINK-28750][Hive]add field comment parse for hive ddl Aug 11, 2022
@hehuiyuan hehuiyuan changed the title [FLINK-28750][Hive]add field comment parse for hive ddl [FLINK-28750][Hive]The field comment for hive ddl has logic error Aug 11, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Aug 11, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hehuiyuan
Copy link
Contributor Author

Hi @luoyuxia @beyond1920 , does it need to be repaired in 1.14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants