[FLINK-28861][table] Make UID generation behavior configurable and plan-only by default #20586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an-only by default Before this commit, due to changes for FLIP-190, every operator generated by the planner got a UID assigned. However, the UID is based on a static counter that might return different results depending on the environment. Thus, UIDs are not deterministic and make stateful restores impossible e.g. when going from 1.15.0 -> 1.15.1. This PR restores the old pre-1.15 behavior for regular Table API. It only adds UIDs if the operator has been created from a compiled plan. A compiled plan makes the UIDs static and thus deterministic. table.exec.uid.generation=ALWAYS exists for backwards compatibility and could make stateful upgrades possible even with invalid UIDs on best effort basis.
twalthr
added a commit
that referenced
this pull request
Aug 16, 2022
…an-only by default Before this commit, due to changes for FLIP-190, every operator generated by the planner got a UID assigned. However, the UID is based on a static counter that might return different results depending on the environment. Thus, UIDs are not deterministic and make stateful restores impossible e.g. when going from 1.15.0 -> 1.15.1. This PR restores the old pre-1.15 behavior for regular Table API. It only adds UIDs if the operator has been created from a compiled plan. A compiled plan makes the UIDs static and thus deterministic. table.exec.uid.generation=ALWAYS exists for backwards compatibility and could make stateful upgrades possible even with invalid UIDs on best effort basis. This closes #20586.
|
Merged in 105d7c9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Backport of #20555.