New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28861][table][docs] Update "upgrading" documentation to includ… #20600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this section @dannycranmer. I tried to make it a bit more precise. The old behavior was not causing issues for every user. As long as the static counter starts at 0 (stable environment), the state can still be restored. This is why the ALWAYS strategy still exists.
@@ -518,7 +518,12 @@ Savepoints are compatible across Flink versions as indicated by the table below: | |||
<td class="text-center"></td> | |||
<td class="text-center"></td> | |||
<td class="text-center">O</td> | |||
<td class="text-left"></td> | |||
<td class="text-left"> | |||
Due to FLIP-190, Flink 1.15.0/1.15.1 changed the way UIDs are generated for TableAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use the release notes that I added in the JIRA issue (slightly adapted):
For Table API: 1.15.0 and 1.15.1 generated non-deterministic UIDs for operators that make it difficult/impossible to restore state or upgrade to next patch version. A new table.exec.uid.generation config option (with correct default behavior) disables setting a UID for new pipelines from non-compiled plans. Existing pipelines can set table.exec.uid.generation=ALWAYS if the 1.15.0/1 behavior was acceptable due to a stable environment.
I tried to be as concise and helpful as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to shorten it if needed for the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I have updated it according to your recommendation, with the addition of a link to the Jira. I do not think it needs shortening, it is not tallest cell in the table. We can always shorten it in the future when it is less relevant.
…e notice regarding the Table API operator issue
551b67f
to
e59859a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @dannycranmer. LGTM.
…e notice regarding the Table API operator issue
What is the purpose of the change
Update documentation to add a notice regarding the Table API operator issue in FLINK-28861
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation