[FLINK-29014][streaming-java][table] Improve end-to-end story about PipelinesOptions.JARS #20633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
changed the title
|
@lsyldliu could you help me with a review? Thanks :) |
Ok, I will review it as soon as possible. |
lsyldliu
approved these changes
Aug 23, 2022
zhuzhurk
reviewed
Aug 23, 2022
...able/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java
Outdated
Show resolved
Hide resolved
…t.getConfiguration StreamExecutionEnvironment.getConfiguration() was not only a ReadableConfig but also a deep copy. This caused various problems downstream (Python API) and makes accessing configuration expensive. Root configuration of TableConfig should not be a snapshot but a reference that always reflects the current status of StreamExecutionEnvironment. Otherwise, when merging e.g. PipelineOptions.JARS, it is possible that entries get lost when an outdated root configuration is used during merging.
…ipelinesOptions.JARS This closes apache#20633.
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…ipelinesOptions.JARS This closes apache#20633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR improves the configuration story in various aspects. The main target is to remove inconsistencies but also a simple architecture under the hood.
Brief change log
StreamExecutionEnvironment.getConfiguration() was not only a ReadableConfig but also a deep copy. This caused various problems downstream (Python API) and makes accessing configuration expensive. Root configuration of
TableConfigshould not be a snapshot but a reference that always reflects the current status of StreamExecutionEnvironment. Otherwise, when merging e.g.PipelineOptions.JARS, it is possible that entries get lost when an outdated root configuration is used during merging.StreamExecutionEnvironment.configure() should not contain merging logic. It should be a set operation as all other options as well.
Table API should apply JAR file paths to TableConfig only. There is logic to apply this to lower layers already.
The same logic should also apply for StreamTableEnvironment.
Also,
PipelineOptions.JARSis not set by default if no jars have been added.Verifying this change
This change added tests and can be verified as follows:
DataStreamJavaITCase#testResourcePropagationDoes this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation