Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flink-26394][FLINK-27148] Fix checkpoint coordinator triggering issue on 1.14 #20682

Open
wants to merge 2 commits into
base: release-1.14
Choose a base branch
from
Open

[Flink-26394][FLINK-27148] Fix checkpoint coordinator triggering issue on 1.14 #20682

wants to merge 2 commits into from

Conversation

pltbkd
Copy link
Contributor

@pltbkd pltbkd commented Aug 26, 2022 •
edited

What is the purpose of the change

This pull request picks the fixes of Flink-26394 and FLINK-27148 to release-1.14, since users using cdc sources on Flink 1.13 may also face the issue.

Brief change log

  • [FLINK-26394] Cancel the checkpoint completable future when checkpoint is aborting.
  • [FLINK-27148] Skip snapshotting the coordinators state or the master state if the pending checkpoint has been disposed.

Verifying this change

This change added tests and can be verified by running the newly added test case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@pltbkd
[FLINK-26394][checkpoint] Cancel the checkpoint completable future wh…
83b5359 
…en checkpoint is aborting.

(cherry picked from commit 31222b9)
@pltbkd
[FLINK-27148][checkpoint] Skip snapshotting the coordinators state or…
0d74aae 
… the master state if the pending checkpoint has been disposed.

This closes apache#19464.

(cherry picked from commit 2c608b8)
@pltbkd
Copy link
Contributor Author

pltbkd commented Aug 26, 2022

@flinkbot run azure

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 26, 2022 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@pltbkd pltbkd marked this pull request as ready for review August 26, 2022 06:23
@pltbkd
Copy link
Contributor Author

pltbkd commented Aug 26, 2022

@flinkbot run azure

@pltbkd pltbkd mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=Runtime/Checkpointing component=Runtime/Network
Projects
None yet
Milestone
No milestone
2 participants
@pltbkd @flinkbot