Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-3713] [clients, runtime] Use user code class loader when disposing savepoints #2083

Closed
wants to merge 3 commits into from
Closed

[FLINK-3713] [clients, runtime] Use user code class loader when disposing savepoints #2083

wants to merge 3 commits into from

Commits on Jul 6, 2016

  1. [FLINK-3713] [clients, runtime] Use user code class loader when dispo… 

    …sing savepoint

Disposing savepoints via the JobManager fails for state handles or descriptors,
which contain user classes (for example custom folding state or RocksDB handles).

With this change, the user has to provide the job ID of a running job when disposing
a savepoint in order to use the user code class loader of that job or provide the
job JARs.

This version breaks the API as the CLI now requires either a JobID or a JAR. I think
this is reasonable, because the current approach only works for a subset of the
available state variants.
    @uce
    uce committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    4427a89 View commit details
    Browse the repository at this point in the history

  2. Address PR comments

    @uce
    uce committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    7e5e3a3 View commit details
    Browse the repository at this point in the history

  3. Remove unused import

    @uce
    uce committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    9671e3f View commit details
    Browse the repository at this point in the history