Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29324] [Connectors/Kinesis] Fix NPE for Kinesis connector when closing #20853

Merged
merged 2 commits into from Sep 20, 2022

Conversation

harker2015
Copy link
Contributor

What is the purpose of the change

Fix the NPE issue when calling Kinesis connector close method before subtask starts running results

Brief change log

  • Check object is null or not before calling

Verifying this change

This change is already covered by added unit test case

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 19, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dannycranmer
Copy link
Contributor

dannycranmer commented Sep 19, 2022

@flinkbot run azure

@dannycranmer
Copy link
Contributor

LGTM. The CI failure is unrelated to this change. I will merge later today, and trigger another CI in the meantime.

@dannycranmer
Copy link
Contributor

@flinkbot run azure

@dannycranmer dannycranmer merged commit 71fea9a into apache:master Sep 20, 2022
dannycranmer pushed a commit that referenced this pull request Sep 20, 2022
…closing (#20853)

* [FLINK-29324] Fix NPE for Kinesis connector when closing

* [FLINK-29324] Add unit test case
dannycranmer pushed a commit that referenced this pull request Sep 20, 2022
…closing (#20853)

* [FLINK-29324] Fix NPE for Kinesis connector when closing

* [FLINK-29324] Add unit test case
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…closing (apache#20853)

* [FLINK-29324] Fix NPE for Kinesis connector when closing

* [FLINK-29324] Add unit test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants